Use Numpy 2.0 for Python 3.9+ packages#1002
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Jun 17, 2024
Merged
Conversation
3ea3d4f to
dbdf6a0
Compare
4 tasks
dbdf6a0 to
00e1209
Compare
| "numpy==1.13.3; python_version=='3.6' and platform_machine != 'aarch64' and platform_machine != 'arm64'", | ||
| "numpy==1.17.0; python_version=='3.7' and platform_machine != 'aarch64' and platform_machine != 'arm64'", | ||
| "numpy==1.17.5; python_version=='3.8' and platform_machine != 'aarch64' and platform_machine != 'arm64'", | ||
| "numpy==1.19.3; python_version<='3.9' and sys_platform == 'linux' and platform_machine == 'aarch64'", |
There was a problem hiding this comment.
We need explicit <2 in setup.py for Python 3.8 and earlier in case of possible expanding of numpy2 releases.
There was a problem hiding this comment.
It would clarify the actual state, but the current version works as well since numpy itself has python_requires>=3.9, so numpy 2.0 and later cannot be installed with older Python versions.
The added constraints here look good to me.
|
🙏 |
This was referenced Jun 17, 2024
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numpy 2.0 is backward compatible with 1.x, but introduce several API and ABI changes. Numpy authors claim, that packages built against Numpy 2.0 should work with 1.x too. The PR introduce additional packages built with Python 3.9 and Numpy 2.0.
Numpy release details: https://github.com/numpy/numpy/releases/tag/v2.0.0
The PR differs from #1001. It builds packages with limited API cp37, but with Python 3.9 and Numpy 2.0. It's expected that the package should work with all supported Pythons 3.7+ and Numpy 1.x and 2.x.