Skip to content

Assign converted value instead of discarding.#45

Merged
odeke-em merged 1 commit intoopencensus-integrations:masterfrom
neilaram1:master
Nov 11, 2020
Merged

Assign converted value instead of discarding.#45
odeke-em merged 1 commit intoopencensus-integrations:masterfrom
neilaram1:master

Conversation

@neilaram1
Copy link
Copy Markdown
Contributor

@neilaram1 neilaram1 commented Nov 11, 2020

This fixes a bug in 7dada5e which
breaks all drivers that do not implement the NamedValueConverter
interface.

@neilaram1
Assign converted value instead of discarding.
8d0b5b3 
This fixes a bug in 7dada5e which
breaks all drivers that do not implement the NamedValueConverter
interface.
@neilaram1
Copy link
Copy Markdown
Contributor Author

neilaram1 commented Nov 11, 2020

@odeke-em PTAL

@neilaram1
Copy link
Copy Markdown
Contributor Author

neilaram1 commented Nov 11, 2020

An example of the error this causes is e.g. pq: encode: unknown type for pq.ByteaArray when using the lib/pq library as a Postgres driver.

odeke-em
odeke-em approved these changes Nov 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @neilaram1!

@odeke-em odeke-em merged commit 30ed618 into opencensus-integrations:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odeke-em odeke-em odeke-em approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@neilaram1 @odeke-em