driver: fixes missing driver.NamedValueChecker implementation#44
Merged
odeke-em merged 1 commit intoopencensus-integrations:masterfrom Nov 10, 2020
Merged
driver: fixes missing driver.NamedValueChecker implementation#44odeke-em merged 1 commit intoopencensus-integrations:masterfrom
odeke-em merged 1 commit intoopencensus-integrations:masterfrom
Conversation
Contributor
Author
|
@odeke-em PTAL |
Member
|
Thank you for this change @micanzhang! However, what if a database doesn't implement that method? This change will break code for other databases. Perhaps you can type assert on it. What's the utility though of adding it? Please explain why we should use it. |
[github.com/go-sql-driver/mysql](https://github.com/go-sql-driver/mysql/blob/master/connection.go#L631) do implement its own CheckNamedValue which used at https://github.com/golang/go/blob/master/src/database/sql/convert.go#L129
Contributor
Author
|
i make some updates when a database driver doesn't implement that interface then use database/sql's default column value convertor; since mysql driver has different implementation of value check, espiciallly for uint64 which supports by mysql driver but illegal when use database/sql |
Contributor
Author
odeke-em
approved these changes
Nov 10, 2020
Member
odeke-em
left a comment
There was a problem hiding this comment.
Gotcha, thank you @micanzhang and LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github.com/go-sql-driver/mysql
do implement its own CheckNamedValue which used at https://github.com/golang/go/blob/master/src/database/sql/convert.go#L129