Skip to content

driver: fixes missing driver.NamedValueChecker implementation#44

Merged
odeke-em merged 1 commit intoopencensus-integrations:masterfrom
micanzhang:master
Nov 10, 2020
Merged

driver: fixes missing driver.NamedValueChecker implementation#44
odeke-em merged 1 commit intoopencensus-integrations:masterfrom
micanzhang:master

Conversation

@micanzhang
Copy link
Copy Markdown
Contributor

@micanzhang
Copy link
Copy Markdown
Contributor Author

@odeke-em PTAL

@odeke-em
Copy link
Copy Markdown
Member

Thank you for this change @micanzhang! However, what if a database doesn't implement that method? This change will break code for other databases. Perhaps you can type assert on it. What's the utility though of adding it? Please explain why we should use it.

@micanzhang
Copy link
Copy Markdown
Contributor Author

i make some updates when a database driver doesn't implement that interface then use database/sql's default column value convertor; since mysql driver has different implementation of value check, espiciallly for uint64 which supports by mysql driver but illegal when use database/sql

@micanzhang
Copy link
Copy Markdown
Contributor Author

micanzhang commented Nov 10, 2020

Copy link
Copy Markdown
Member

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, thank you @micanzhang and LGTM!

@odeke-em odeke-em merged commit 7dada5e into opencensus-integrations:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants