Add DisableErrSkip option to span status

[a8m]

Adding a DisableErrSkip option to TraceOptions in order to be able to suppress driver.ErrSkip errors in spans.

Right now, it's really annoying to see many "non-real failures" reporting in the tracing dashboard (many spans with status != 0), since ocsql sets the span's status to non zero when the error is driver.ErrSkip, which is not a real failure.

I'm keeping the behavior backward compatible by disabling the error reporting only when this option is being set explicitly.

Attaching here screenshots with before/after:

• Before:

• After - spans with driver.ErrSkip still hold the message, but are not reported as errors:

Awesome package, thanks for creating this.

[jcchavezs]

Totally. This issue was addressed in zipkin instrumentation for go SQL: https://github.com/jcchavezs/zipkin-instrumentation-sql/pull/3 søn. 23. jun. 2019, 23:35 skrev Ariel Mashraki <notifications@github.com>:

…

Adding a DisableErrSkip option to TraceOptions in order to be able to suppress driver.ErrSkip <https://golang.org/pkg/database/sql/driver/#ErrSkip> errors in spans. Right now, it's really annoying to see many "non-real failures" reporting in the tracing dashboard (many spans with status != 0), since ocsql sets the span's status to non zero when the error is driver.ErrSkip <https://golang.org/pkg/database/sql/driver/#ErrSkip>, which is not a real failure. I'm keeping the behavior backward compatible by disabling the error reporting only when this option is being set explicitly. Attaching here screenshots with before/after: - Before: [image: before1] <https://user-images.githubusercontent.com/7413593/59982208-52dadc80-9617-11e9-8e28-cd6d988a72c6.png> [image: before2] <https://user-images.githubusercontent.com/7413593/59982207-52dadc80-9617-11e9-85b9-e015f869b6ec.png> - After - span with driver.ErrSkip still hold the message, but are not reported as errors: [image: after 1] <https://user-images.githubusercontent.com/7413593/59982239-b9f89100-9617-11e9-8a7c-b3ea1f0e0bbf.png> Awesome package, thanks for creating this. ------------------------------ You can view, comment on, or merge this pull request online at: #37 Commit Summary - Add DisableErrSkip option to span status File Changes - *M* driver.go <https://github.com/opencensus-integrations/ocsql/pull/37/files#diff-0> (45) - *M* options.go <https://github.com/opencensus-integrations/ocsql/pull/37/files#diff-1> (10) Patch Links: - https://github.com/opencensus-integrations/ocsql/pull/37.patch - https://github.com/opencensus-integrations/ocsql/pull/37.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#37?email_source=notifications&email_token=AAXOYAWQMIID3JKABASAKC3P37UBNA5CNFSM4H2Z2LB2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G3FIBYQ>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAXOYAQ5NO5W7R25BXDCOG3P37UBNANCNFSM4H2Z2LBQ> .

[odeke-em]

Thank you for working on this @a8m and welcome to the ocsql project!

I've added a small suggestion but otherwise LGTM!