Fix span attributes & option propagation for transaction related spans#34
Merged
odeke-em merged 2 commits intoopencensus-integrations:masterfrom Mar 6, 2019
lwc:master
Merged
Fix span attributes & option propagation for transaction related spans#34odeke-em merged 2 commits intoopencensus-integrations:masterfrom lwc:master
odeke-em merged 2 commits intoopencensus-integrations:masterfrom
lwc:master
Conversation
Member
|
I also updated your commit message to reflect the change, thank you again! |
Member
|
Wow for some reason Github registered this as my commit, my apologies @lwc! Something tripped out with the Github UI. However it is still attributed to you. |
Contributor
Author
|
Thanks for the fast response! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a couple of bugs when using this package:
sql:begin_transactiondue to the execution order of multiple defersTraceOptions