Skip to content

Fix span attributes & option propagation for transaction related spans#34

Merged
odeke-em merged 2 commits intoopencensus-integrations:masterfrom
lwc:master
Mar 6, 2019
Merged

Fix span attributes & option propagation for transaction related spans#34
odeke-em merged 2 commits intoopencensus-integrations:masterfrom
lwc:master

Conversation

@lwc
Copy link
Copy Markdown
Contributor

@lwc lwc commented Mar 6, 2019

I noticed a couple of bugs when using this package:

  • All span attributes are missing from sql:begin_transaction due to the execution order of multiple defers
  • All transaction spans are missing TraceOptions

Copy link
Copy Markdown
Member

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for this change @lwc! LGTM and perhaps this is the time for us to add such tests as the issue here was that span.End was getting invoked before attributes were added

@odeke-em odeke-em merged commit 88d7880 into opencensus-integrations:master Mar 6, 2019
@odeke-em
Copy link
Copy Markdown
Member

odeke-em commented Mar 6, 2019

I also updated your commit message to reflect the change, thank you again!

@odeke-em
Copy link
Copy Markdown
Member

odeke-em commented Mar 6, 2019

Wow for some reason Github registered this as my commit, my apologies @lwc! Something tripped out with the Github UI. However it is still attributed to you.

@lwc
Copy link
Copy Markdown
Contributor Author

lwc commented Mar 6, 2019

Thanks for the fast response! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants