Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Fixes enum naming bug#72

Merged
spacether merged 5 commits intomasterfrom
fixes_enum_names
Nov 10, 2022
Merged

Fixes enum naming bug#72
spacether merged 5 commits intomasterfrom
fixes_enum_names

Conversation

@spacether
Copy link
Copy Markdown
Contributor

@spacether spacether commented Nov 10, 2022

Fixes enum naming bug
This happens when an invalid first character is stripped
All remaining characters satisfy the character 1+ regex requirements. But the remaining first character does
NOT satisfy the regex requirements on the first character.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether linked an issue Nov 10, 2022 that may be closed by this pull request
6 tasks
@spacether spacether added this to the 1.0.3 milestone Nov 10, 2022
@spacether spacether merged commit 5fc90e2 into master Nov 10, 2022
@spacether spacether deleted the fixes_enum_names branch November 10, 2022 21:08
@spacether
Copy link
Copy Markdown
Contributor Author

Not sure what you are asking. Can you make your question simpler or give examples?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Invalid function names based on strings containing # and digits

1 participant