Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Removes AbstractXGenerators#351

Merged
spacether merged 13 commits intomasterfrom
refactor_consolidates_generator_classes
Jan 8, 2024
Merged

Removes AbstractXGenerators#351
spacether merged 13 commits intomasterfrom
refactor_consolidates_generator_classes

Conversation

@spacether
Copy link
Copy Markdown
Contributor

@spacether spacether commented Jan 6, 2024

  • Removes deprecated methods and class
  • Removes AbstractPythonGenerator, its code is put into the python generator
  • Removes AbstractJavaGenerator, its code is put into the java generator
  • Removes CodegenSchema.isInline

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether changed the title Removes deprecated methods Removes AbstractXGenrators Jan 7, 2024
@spacether spacether changed the title Removes AbstractXGenrators Removes AbstractXGenerators Jan 7, 2024
@spacether spacether merged commit 3f5c532 into master Jan 8, 2024
@spacether spacether deleted the refactor_consolidates_generator_classes branch January 8, 2024 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant