Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Removes unused org.codehaus.janino library#319

Merged
spacether merged 1 commit intomasterfrom
feat_removes_unused_logging_lib
Dec 4, 2023
Merged

Removes unused org.codehaus.janino library#319
spacether merged 1 commit intomasterfrom
feat_removes_unused_logging_lib

Conversation

@spacether
Copy link
Copy Markdown
Contributor

Removes unused org.codehaus.janino library

The latest version of logback requires org.codehaus.janino to evaulate conditional logic per https://stackoverflow.com/questions/11017148/how-does-the-condition-functionality-work-in-logback. In this case the logback config doesn't use conditional logic so it is not needed. I will remove it.
per #317 (comment)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether merged commit 20af44e into master Dec 4, 2023
@spacether spacether deleted the feat_removes_unused_logging_lib branch December 4, 2023 21:19
@spacether
Copy link
Copy Markdown
Contributor Author

Hmm actually there are conditionals like <if condition='isDefined("color")'> not sure how they work without org.codehaus.janino

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant