Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Java, adjusts validation method names in JsonSchema#309

Merged
spacether merged 9 commits intomasterfrom
feat_java_chnanges_validate_method_names
Dec 1, 2023
Merged

Java, adjusts validation method names in JsonSchema#309
spacether merged 9 commits intomasterfrom
feat_java_chnanges_validate_method_names

Conversation

@spacether
Copy link
Copy Markdown
Contributor

@spacether spacether commented Dec 1, 2023

Java, adjusts validation method names in JsonSchema

  • JsonSchema should expose only one validate method which accepts Object
  • this keeps the schemas that extend JsonSchema's validate signatures simpler
  • updates number/integer validate methods to not mutate inputs, so Int32 can accept a float per json schema tests

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether merged commit 3baa4b2 into master Dec 1, 2023
@spacether spacether deleted the feat_java_chnanges_validate_method_names branch December 1, 2023 23:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant