Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Fixes mypy redundant casts issue#251

Merged
spacether merged 4 commits intomasterfrom
fix_mypy_redundant_casts
Oct 9, 2023
Merged

Fixes mypy redundant casts issue#251
spacether merged 4 commits intomasterfrom
fix_mypy_redundant_casts

Conversation

@spacether
Copy link
Copy Markdown
Contributor

@spacether spacether commented Oct 6, 2023

  • Fixes mypy redundant casts issue
  • verification tests added

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether marked this pull request as draft October 6, 2023 19:21
@spacether spacether marked this pull request as ready for review October 9, 2023 20:11
@spacether spacether merged commit d75e7ad into master Oct 9, 2023
@spacether spacether deleted the fix_mypy_redundant_casts branch October 9, 2023 20:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ][python] get user's mypy check passing with warn_redundant_casts turned on

1 participant