[BUG] ThisSchema.additionalProperties = ThisSchema causes StackOverflowError

[spacether]

Bug Report Checklist

• Have you provided a full/minimal spec to reproduce the issue?
• Have you validated the input using an OpenAPI validator (example)?
• Have you tested with the latest master to confirm the issue still exists?
• Have you searched for related issues/PRs?
• What's the actual output vs expected output?
• [Optional] Sponsorship to speed up the bug fix or feature request (example)

Description

ThisSchema.additionalProperties = ThisSchema causes StackOverflowError
When an object schema defines additionalProperties as itself we get a StackOverflowError
Sample spec

    Player:
      type: object
      description: a model that includes a self reference this forces properties and additionalProperties
                   to be lazy loaded in python models because the Player class has not fully loaded when defining
                   properties + additionalProperties
      properties:
        name:
          type: string
        enemyPlayer:
          $ref: '#/components/schemas/Player'
      additionalProperties:
        $ref: '#/components/schemas/Player'

This bug probably also exists for ArrayModels containing themself in items

openapi-generator version

OpenAPI declaration file content or url

Generation Details

Steps to reproduce

Related issues/PRs

Suggest a fix

The overflow happens when creating example values for schemas. Build in the ability to detect a cycle where we return to a previously visited schema and and halt in teExampleValueRecursive

[spacether]

The goal is to have this fixed in the 2.0.0 release which will better handle self references

[spacether]

This will be fixed in the linked PR and one can see it working here:

class SelfReferencingObjectModel(
    schemas.DictSchema
):
    """NOTE: This class is auto generated by OpenAPI Generator.
    Ref: https://openapi-generator.tech
    Do not edit the class manually.
    """


    class MetaOapg:
        types = {frozendict.frozendict}
        
        class Properties:
        
            @staticmethod
            def self_ref() -> typing.Type['SelfReferencingObjectModel']:
                return SelfReferencingObjectModel
            __annotations__ = {
                "selfRef": self_ref,
            }
        
        @staticmethod
        def additional_properties() -> typing.Type['SelfReferencingObjectModel']:
            return SelfReferencingObjectModel
    
    @typing.overload
    def __getitem__(self, name: typing_extensions.Literal["selfRef"]) -> 'SelfReferencingObjectModel': ...
    
    @typing.overload
    def __getitem__(self, name: str) -> 'SelfReferencingObjectModel': ...
    
    def __getitem__(
        self,
        name: typing.Union[
            typing_extensions.Literal["selfRef"],
            str
        ]
    ):
        # dict_instance[name] accessor
        return super().__getitem__(name)
    
    @typing.overload
    def get_item_oapg(self, name: typing_extensions.Literal["selfRef"]) -> typing.Union['SelfReferencingObjectModel', schemas.Unset]: ...
    
    @typing.overload
    def get_item_oapg(self, name: str) -> typing.Union['SelfReferencingObjectModel', schemas.Unset]: ...
    
    def get_item_oapg(
        self,
        name: typing.Union[
            typing_extensions.Literal["selfRef"],
            str
        ]
    ):
        return super().get_item_oapg(name)

    def __new__(
        cls,
        *_args: typing.Union[dict, frozendict.frozendict, ],
        selfRef: typing.Union['SelfReferencingObjectModel', schemas.Unset] = schemas.unset,
        _configuration: typing.Optional[schemas.Configuration] = None,
        **kwargs: 'SelfReferencingObjectModel',
    ) -> 'SelfReferencingObjectModel':
        return super().__new__(
            cls,
            *_args,
            selfRef=selfRef,
            _configuration=_configuration,
            **kwargs,
        )

[spacether]

Feature is available in the 2.0.0 release