fix: revert required_ruby_version to >=2.4 for 1.10.x#230
Merged
bufferoverflow merged 1 commit intoomniauth:release/1.10.xfrom Sep 18, 2024
Merged
Conversation
c467c01 to
5abd24d
Compare
Member
Contributor
Author
|
Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #228, it was noted that the required_ruby_version setting for the gem was bumped between gem version 2.1.0 to 2.1.1. This was addressed in e9d5238 and released as gem version 2.1.2.
Earlier today, gem version 1.10.4 was released in order to resolve GHSA-cvp8-5r8g-fhvq for older rubies (ref #229), however this also highlights an earlier case in which the required_ruby_version setting was bumped during a patch release. In this case, between gem version 1.10.1 and 1.10.2, required_ruby_version was bumped from >=2.1 to >=2.4.
With this PR, I am requesting that the required_ruby_version change made in gem version 1.10.2 be reverted in order to expand the ability for users stuck on the 1.10.x tree to resolve GHSA-cvp8-5r8g-fhvq.