fix: use npmFetch() instead of npmFetch.json() for team destroy command#6161
Merged
wraithgar merged 6 commits intonpm:latestfrom Feb 14, 2023
Merged
Conversation
The registry returns a 204 status and an empty body on success for the team destroy command. Using npmFetch.json() makes the CLI error out on completion even though the action was completed successfully in the registry.
Contributor
Author
|
Looks like I have to publish a new version of |
68f511e to
65475ce
Compare
Return a value of empty JSON {} object to have a known response for the
empty response body. Otherwise the npmFetch returns the Body object from
minipass package.
Contributor
|
It'd be good if we caught the correct behavior in the tests. Can you remove the |
heisantosh
commented
Feb 14, 2023
wraithgar
reviewed
Feb 14, 2023
… and update tests
Contributor
|
Fixed PR to use same delete behavior as libnpmaccess |
lukekarrys
approved these changes
Feb 14, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The registry returns a HTTP 204 status and an empty body on success for the
npm team destroy <org>:<team>command. UsingnpmFetch.json()makes the CLI error out on completion even though the action was completed successfully in the registry.Using
npmFetch()will not attempt to parse the response body as JSON.