Skip to content

console: do not emit error events#9744

Closed
addaleax wants to merge 3 commits intonodejs:masterfrom
addaleax:console-no-errors2
Closed

console: do not emit error events#9744
addaleax wants to merge 3 commits intonodejs:masterfrom
addaleax:console-no-errors2

Conversation

@addaleax
Copy link
Copy Markdown
Member

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

console

Description of change

Never fail for streams errors resulting from the console.* methods.

I know relatively little about the backstory here, so feel free to shoot this down quickly if it’s already been discussed and discarded.

/cc @Fishrock123

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

console Issues and PRs related to the console subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants