stream: remove duplicated utility#63031
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom May 4, 2026
Merged
Conversation
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63031 +/- ##
==========================================
- Coverage 89.65% 89.64% -0.02%
==========================================
Files 708 708
Lines 220374 220356 -18
Branches 42264 42262 -2
==========================================
- Hits 197584 197539 -45
- Misses 14656 14681 +25
- Partials 8134 8136 +2
π New features to boost your workflow:
|
Collaborator
Collaborator
jasnell
approved these changes
May 4, 2026
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/63031 β Done loading data for nodejs/node/pull/63031 ----------------------------------- PR info ------------------------------------ Title stream: remove duplicated utility (#63031) β Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:remove-duplicate-non-writable-util -> nodejs:main Labels lib / src, author ready, needs-ci Commits 1 - stream: remove duplicated utility Committers 1 - Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/63031 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/63031 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- βΉ This PR was created on Wed, 29 Apr 2026 09:52:23 GMT β Approvals: 2 β - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/63031#pullrequestreview-4211377766 β - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/63031#pullrequestreview-4221332527 β Last GitHub CI successful βΉ Last Full PR CI on 2026-05-04T14:59:10Z: https://ci.nodejs.org/job/node-test-pull-request/73092/ - Querying data for job/node-test-pull-request/73092/ β Build data downloaded β Last Jenkins CI successful -------------------------------------------------------------------------------- β No git cherry-pick in progress β No git am in progress β No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD β origin/main is now up-to-date - Downloading patch for 63031 From https://github.com/nodejs/node * branch refs/pull/63031/merge -> FETCH_HEAD β Fetched commits as 25f80fb7647d..d76d3716b1a0 -------------------------------------------------------------------------------- Auto-merging lib/internal/webstreams/util.js [main 129daec137] stream: remove duplicated utility Author: Antoine du Hamel <duhamelantoine1995@gmail.com> Date: Wed Apr 29 11:50:07 2026 +0200 5 files changed, 33 insertions(+), 51 deletions(-) β Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- stream: remove duplicated utility
|
aduh95
added a commit
that referenced
this pull request
May 5, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #63031 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And reorder the object keys in ASCII-order (only a few were slightly off, couldn't help myself)