Skip to content

crypto: pass all WebCryptoAPI WPTs#43656

Closed
panva wants to merge 17 commits intonodejs:mainfrom
panva:webcrypto-wpt
Closed

crypto: pass all WebCryptoAPI WPTs#43656
panva wants to merge 17 commits intonodejs:mainfrom
panva:webcrypto-wpt

Conversation

@panva
Copy link
Copy Markdown
Member

@panva panva commented Jul 2, 2022

I'm not expecting to land this PR as-is but i'm seeking feedback from @nodejs/crypto namely @tniessen and @jasnell on the end state which this currently reflects.

Overall the question is - is passing all relevant WebCryptoAPI WPT worth the ❗ items?

  • update WebCryptoAPI WPT
  • OperationError for generateKey() AES key length validation
  • NotSupportedError for generateKey() and importKey() EC key namedCurve validation
  • OperationError for HKDF deriveBits() length being null
  • ❗ support for zero-length secret KeyObject
  • OperationError for PBKDF2 deriveBits() iterations being 0
  • OperationError for PBKDF2 deriveBits() length being null
  • OperationError for when async crypto jobs fail for operation specific reasons
  • ❗ workaround for openssl EVP_PKEY_derive HKDF not playing nice with zero-length IKM
  • WPT global.location polyfill so that wpt/common/subset-tests.js execute

The C++ linter fails due to variable-length array use and I'd like suggestions for the C++ changes anyway.

I would still break this down into more individual commits. Or PRs if that's what the ask will be.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. review wanted PRs that need reviews. webcrypto

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants