fix: check AbortSignal in handleAutomaticTaskPolling to stop cancelled requests#2019
Open
blackwell-systems wants to merge 3 commits intomodelcontextprotocol:mainfrom
Conversation
…d requests The while loop in handleAutomaticTaskPolling polls indefinitely without checking ctx.mcpReq.signal.aborted. If a client cancels the request, the poll loop continues consuming server resources. The taskManager.ts implementation of the same pattern correctly checks signal.aborted (line 856). This brings handleAutomaticTaskPolling in line with that behavior. Fixes modelcontextprotocol#2018
🦋 Changeset detectedLatest commit: d1df061 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleAutomaticTaskPollingpolls a task store in a while loop without checkingctx.mcpReq.signal.aborted. Cancelled requests continue polling indefinitely, leaking server resources.Motivation and Context
The
taskManager.tsimplementation correctly checks the signal for the same polling pattern (line 856). This bringshandleAutomaticTaskPollingin line with that behavior.How Has This Been Tested?
Existing tests pass. The change adds an early exit condition that only fires when the request's AbortSignal has been triggered (client cancellation).
Fixes #2018