Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-null-arguments-internal-error.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@modelcontextprotocol/core': patch
---

Accept null arguments in tools/call requests and return -32602 (InvalidParams) instead of -32603 (InternalError) for request validation failures. Clients that serialize missing fields as null (common in Go, Java, C# JSON libraries) no longer get an opaque internal error when calling tools.
5 changes: 4 additions & 1 deletion packages/core/src/shared/protocol.ts
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,10 @@ export abstract class Protocol<ContextT extends BaseContext> {
const schema = getRequestSchema(method as RequestMethod);
this._requestHandlers.set(method, (request, ctx) => {
// Validate request params via Zod (strips jsonrpc/id, so we pass original to handler)
schema.parse(request);
const result = schema.safeParse(request);
if (!result.success) {
throw new ProtocolError(ProtocolErrorCode.InvalidParams, `Invalid ${method} request: ${result.error.message}`);
}
return handler(request, ctx);
});
},
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/types/schemas.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1417,7 +1417,7 @@ export const CallToolRequestParamsSchema = TaskAugmentedRequestParamsSchema.exte
/**
* Arguments to pass to the tool.
*/
arguments: z.record(z.string(), z.unknown()).optional()
arguments: z.preprocess(val => val ?? undefined, z.record(z.string(), z.unknown()).optional())
});

/**
Expand Down
53 changes: 53 additions & 0 deletions packages/core/test/types.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {
CallToolRequestSchema,
CallToolResultSchema,
ClientCapabilitiesSchema,
CompleteRequestSchema,
Expand Down Expand Up @@ -985,6 +986,58 @@ describe('Types', () => {
});
});

describe('CallToolRequest arguments handling', () => {
test('should accept tools/call with arguments as object', () => {
const request = {
method: 'tools/call',
params: {
name: 'echo',
arguments: { message: 'hello' }
}
};
const result = CallToolRequestSchema.safeParse(request);
expect(result.success).toBe(true);
});

test('should accept tools/call with arguments omitted', () => {
const request = {
method: 'tools/call',
params: {
name: 'echo'
}
};
const result = CallToolRequestSchema.safeParse(request);
expect(result.success).toBe(true);
if (result.success) {
expect(result.data.params.arguments).toBeUndefined();
}
});

test('should accept tools/call with arguments as null', () => {
const request = {
method: 'tools/call',
params: {
name: 'echo',
arguments: null
}
};
const result = CallToolRequestSchema.safeParse(request);
expect(result.success).toBe(true);
});

test('should accept tools/call with arguments as empty object', () => {
const request = {
method: 'tools/call',
params: {
name: 'echo',
arguments: {}
}
};
const result = CallToolRequestSchema.safeParse(request);
expect(result.success).toBe(true);
});
});

describe('ElicitRequestFormParamsSchema', () => {
test('accepts requestedSchema with extra JSON Schema metadata keys', () => {
// Mirrors what z.toJSONSchema() emits — includes $schema, additionalProperties, etc.
Expand Down
Loading