variable.other.constant.ts only matches all-caps constant declarations

[mjbvz]

From @Janne252 on July 26, 2018 8:24

• VSCode Version: 1.25.1
• OS Version: Windows 10 Pro 64-bit

Steps to Reproduce:

1. Open an empty folder in VS Code
2. Create a new TypeScript file with the following content:

declare const Foo: string;
declare const BAR: string;

3. Add the following setting to the workspace settings:

    "editor.tokenColorCustomizations": {
        "textMateRules": [
            {
                "scope": "variable.other.constant.ts",
                "settings": {
                    "foreground": "#FF0000"
                }
            }
        ]   
    }

4. Enable "Developer: Inspect TM Scopes"
5. Inspect the TextMate scopes of the constants Foo and BAR
   
   Note how the constant in all caps is scoped as variable.other.constant.ts
   
   Note how the constant in camel case is incorrectly scoped as variable.other.readwrite.ts

Does this issue occur when all extensions are disabled?: Yes

Copied from original issue: microsoft/vscode#55119

[mjbvz]

Likely duplicate of #542

[Janne252]

Apologies for the duplicate. Looks like this was the nudge it needed to push it over the edge, it appers to have been fixed in a commit. Thanks @sheetalkamat!