Units selection#558
Merged
marionbarker merged 14 commits intodevfrom May 3, 2026
Merged
Conversation
- Introduced UnitSettingsStore to centralize unit and metric settings management. - Added new enums for glucose display units, time in range modes, glycemic metrics, and variability metrics. - Updated StatsData to calculate and store coefficient of variation. - Refactored Localizer to utilize UnitSettingsStore for unit conversions and formatting. - Enhanced Nightscout and Dexcom settings views to support unit configuration and onboarding. - Created UnitsConfigurationView for reusable unit and metric settings. - Updated AggregatedStatsView and SimpleStatsViewModel to reflect new unit settings. - Modified TIRView and its ViewModel to use UnitSettingsStore for thresholds and display. - Removed legacy storage references for unit settings in favor of the new centralized approach. - Added export functionality for new unit and metric settings in Nightscout settings.
…e hour and minute states, enhancing clarity and usability
Member
|
hasConfiguredUnits is written to, but never used. Should it be removed? |
Member
|
Graph lines ignore user's high/low settings (Graphs.swift) — graphRangeThresholds() hardcodes low = 70.0 and high = 140.0/180.0. Users who customized lowLine/highLine in Graph Settings will see those settings silently ignored for graph rendering and dot coloring. At the same time, BG coloring could be based on range? So the question is, should we force users to use TIR/TITR and remove the customized settings.. or should there be TIR/TITR/Custom where when you select custom can choose those values just like before (and keep them if they already had them..) |
# Conflicts: # LoopFollow/Stats/AggregatedStatsView.swift
bjorkert
approved these changes
Apr 10, 2026
Member
|
Added a custom range, solved conflicts with dev. |
Accidentally committed utility script that belongs outside the project.
Use @State for glucoseUnit, lowValue, and highValue so SwiftUI can track changes and re-render. Add .id(glucoseUnit) on BGPickers to force recreation when the unit changes, ensuring allValues and formatting update correctly.
Member
|
bjorkert
added a commit
that referenced
this pull request
Apr 27, 2026
# Conflicts: # LoopFollow/Application/Base.lproj/Main.storyboard # LoopFollow/Controllers/MainViewController+updateStats.swift # LoopFollow/Nightscout/NightscoutSettingsView.swift # LoopFollow/ViewControllers/MainViewController.swift
marionbarker
approved these changes
May 3, 2026
Collaborator
marionbarker
left a comment
There was a problem hiding this comment.
Cursory code review - relied on @bjorkert approval.
Approved by test.
MtlPhil
pushed a commit
to achkars-org/LoopFollow
that referenced
this pull request
May 6, 2026
Brings in all changes from loopandlearn/LoopFollow dev up to 6.1.0. Resolved conflicts by taking upstream throughout, except LogManager where both the watch and telemetry log categories are kept. Key changes from upstream: - Add iOS 17.2+ push-to-start for Live Activity renewal (loopandlearn#622) - Fix LA restart classification, foreground race, troubleshooting logs (loopandlearn#615) - Redact secrets from log output (loopandlearn#623) - Add anonymous telemetry (loopandlearn#626) - Add units selection (loopandlearn#558) - Fix stats inclusive date range (loopandlearn#629) - Deduplicate Nightscout treatment entries by id (loopandlearn#569) - Fix alarm sound session activation failures in background (loopandlearn#596) - Recognize Atlas DASH pod in Omnipod heartbeat scan (loopandlearn#633) - Default migrationStep to latest on fresh installs (loopandlearn#631) - Update to fastlane 2.233.1 (loopandlearn#632) https://claude.ai/code/session_01VK2furpEaEmysQvEd1h77f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR centralizes glucose unit and metric preferences, adds a reusable units onboarding flow, and updates stats and setup screens to use the new configuration model. It also documents commit message conventions in the README.
What changed