Fail on classpath resource names that are blank after removing leading slash#4761
Merged
marcphilipp merged 3 commits intomainfrom Jul 16, 2025
Merged
Conversation
3e6aa83 to
e123ed6
Compare
2 tasks
marcphilipp
commented
Jul 12, 2025
mpkorstanje
reviewed
Jul 12, 2025
Contributor
mpkorstanje
left a comment
There was a problem hiding this comment.
I think this will work as expected.
I've made a suggestion for a DiscoverySelector.toSource() method, but that could be pushed to v6.
b5f7605 to
4eb5925
Compare
sormuras
approved these changes
Jul 14, 2025
4eb5925 to
40812a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4752.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations