Skip to content

Enmerge 241104#745

Merged
joaquinelio merged 87 commits intomasterfrom
enmerge
Nov 11, 2024
Merged

Enmerge 241104#745
joaquinelio merged 87 commits intomasterfrom
enmerge

Conversation

@joaquinelio
Copy link
Copy Markdown
Member

Super Sync
too long time without

wdscxsj and others added 30 commits October 3, 2022 16:58
Fixing a minor grammatical typo in the selection and range markdown document.
Add WeakRef and FinalizationRegistry article
Fix broken link to compat-table
Fix broken link to compat-table
Replace the assignment operator `=` with the equality comparison `==` in both examples in the 'Truncate the text' task.
Fix the broken link in Chapter 3.6
Replace assignment with equals in Truncate the text task
Improve awkward sentence structure
Updated RFC spec Safe Methods URL in Cookies chapter
smith558 and others added 6 commits July 10, 2024 16:11
change example element of multidimensional array
Fixing a minor grammatical typo in the document.
The code uses the function named 'askPassword' but the text above it explaining the error reason says 'ask' instead of 'askPassword'
minor fix to function name written in explanation
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 5, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
6 out of 25 committers have signed the CLA.

✅ joaquinelio
✅ WOLFRIEND
✅ iliakan
✅ smith558
✅ kricsleo
✅ Alexandre887
❌ wdscxsj
❌ JaFro96
❌ sagarpanchal
❌ CJDumbleton
❌ mikayel00
❌ nepikn
❌ qadzek
❌ Filin3
❌ nakhodkin
❌ eedrxs
❌ alexandermirzoyan
❌ rahulrao0209
❌ ellie-heidari
❌ sneeed
❌ pvepamb1
❌ shallow-beach
❌ FloffyGarlic
❌ 0xtpsl
❌ tonybishnoi
You have signed the CLA already but the status is still pending? Let us recheck it.

@joaquinelio joaquinelio marked this pull request as ready for review November 6, 2024 00:59
@joaquinelio
Copy link
Copy Markdown
Member Author

1ra autorevision - cambios menores

no autorevisé cookies OJO
varias correcciones relevantes y de claridad
muy bueno el original

Qué cambios absurdos que hay en este merge
Ma arrepiento de haberlos trasladado.
No puedo cambiar estilo ni escribir lo q se me cante, pero puedo negarme a traducir basura, Bué, ya está.
Algunos cambios son relevantes.

Qué porquería los art añadidos
O no. Muy minuciosos, muy trabajados. Pero no van con el foco del tutorial, demasiado esfuerzo exige para un tema poco usable que estaba suficientemente bien tratado weakref
Pero acá sí, no es mi prerrogativa decidir lo que entra.

@joaquinelio
Copy link
Copy Markdown
Member Author

modificado cookies y el resto
re revisar

@joaquinelio
Copy link
Copy Markdown
Member Author

review llimpia,
falta cookies

@joaquinelio
Copy link
Copy Markdown
Member Author

looks good
autoreview
sorry
but I need to avoid merges piling up
not again

@joaquinelio joaquinelio merged commit 97e90e0 into master Nov 11, 2024
@joaquinelio joaquinelio deleted the enmerge branch November 11, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.