Susy201113#441
Merged
joaquinelio merged 65 commits intojavascript-tutorial:masterfrom Nov 20, 2020
Merged
Conversation
Commit 10d1b1f added a hint about which word would be found by a certain regexp: "A call to str.match(/\w+/) will find only the first word in the line (var). That’s not it." Unfortunately the result is incorrect: the regexp would find `let`, not `var`. Updating the hint should resolve any confusion. The example has been tested in the console to ensure that the regexp does indeed return `let`.
Strictly speaking, there is no error here, as `typeof` does not produce errors with undefined variables.
Now this chapter is at the end of the general section.
FIX: delete extra space
Fix semicolons in 1.11.1 (Introduction: callbacks)
promisiefy -> promisify
Correct solution explanation in 1.99.04 (Reference Type)
Fix link in 2.1.5 (Node properties...)
It can be more readable with same line of code. There was a lot of nested parenthesis.
Fix a typo in 1.11.3 (Promises chaining)
Fix typo in 2.1.6 (Attributes and properties)
look like ninja code
fix typo in 06-promisify article.md
Fix typos in 2.1.4 (Searching elements)
FIX: delete extra space
Fix a typo in 1.6.1 task solution
Fix a possible typo in 1.6.1
OPT: change "false" to "falsy"
FIX: change ; to ,
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cambios descartados y pasados a issues
1-11-6 promisify article
varios cambios,
pero no como para rehacerlo. Sugiero ver history o blame del ingles
1-8-1 prototype inherit
solo 2 cambios muy localizados, varias lineas
Sugiero ver history o blame del ingles
1-4-7 optional chaining
varios agregados por lo tanto num lineas trastocado
quizas sea mejor usar diff