Susy201029#438
Merged
joaquinelio merged 109 commits intojavascript-tutorial:masterfrom Nov 12, 2020
Merged
Conversation
1. Without a real sorting part, the data output is not the same as with real sort (as the array is not really sorted when the callback returns `undefined`). 2. Current example may somehow encourage a reader to write sorting callbacks with undetermined behavior.
As of the last versions of V8 (i.e. Chrome and Node.js), the current info seems outdated. See also https://v8.dev/blog/array-sort
The page of the current link has not this anchor anymore.
Proposed solution is in sync with some previous sort function examples. It also makes sorting stable (does not skip `0` result).
Fix link in 1.5.3
Make a solution of 1.5.5 task more correct
Fix a typo in a 1.5.5 task solution
Mention arr.flat()/arr.flatMap() in 1.5.5
Add a note on some()/every() short circuit
Fix some possible typos and omissions in 1.5.5
Correct outdated info
Fix typos in 1.5.3
Make code example more realistic and safe
This updates a small grammar error and adds some helpful info. Hoping it's better now. Let me know if you need any more changes and I'll update it immediately.
Updated based on suggestion on issue #1769
Update task.md
It seems there are no polymorphic functions in this chapter.
Fix possibly outdated note in 1.9.6 (instanceof)
Include "object" in MDN link
Update task.md
Minor clarification on WeakMap and WeakSet
Replace rules.indent array with number
Update topic sentence
Fix links in 1.8.4 (Prototype methods)
Add emphasis for clarity
Update article.md
Delete excess semicolon in 1.9.1 (Class basic syntax)
Clarify task code place in 1.9.1 (Class basic syntax)
Add missing semicolons in 1.9.2 (Class inheritance)
Member
Author
Al hacer merge revisar:1-5-8 article WeakMap y WeakSet Cambios descartados y pasados a issues:1-4-7 optional-chaining article , 9-16 regexp-sticky article |
vplentinax
approved these changes
Nov 7, 2020
Contributor
vplentinax
left a comment
There was a problem hiding this comment.
Pequeñas correcciones...
Co-authored-by: ᐯᑭᒪEᑎTIᑎᗩ᙭ ᐯᑭ <34555644+vplentinax@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.