Susy primavera super sync#406
Merged
joaquinelio merged 167 commits intojavascript-tutorial:masterfrom Oct 7, 2020
Merged
Conversation
My proposed change may not be right, but "make a request to URL" was unclear, and it's `fetch` that's used below to make the request. If 'request to URL' has some special meaning and is what you want to say, maybe some rephrasing is in order.
Confucius never said anything about black cat Ref: https://www.washingtonpost.com/world/2019/03/25/chinese-proverb-that-russia-cited-respond-mueller-report-does-not-appear-be-chinese-proverb/
"// obj.toString === obj.__proto__.toString == Object.prototype.toString" It is look like JS code but it gives different result from what we want to get. There is different kind of equality operator ant these give more confusing what is the purpose of these? It can be better to separate this line into 2 line of code to make it sensible and readable. Subject and code is already hard but there is no need to make readers ask unnecessary questions.
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
Adding the missin closing bracket.
vplentinax
requested changes
Oct 7, 2020
|
Please make the requested changes. After it, add a comment "/done". |
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
vplentinax
approved these changes
Oct 7, 2020
Contributor
vplentinax
left a comment
There was a problem hiding this comment.
Ok, creo que se puede avanzar. Merge.
Member
Author
|
/done |
Member
Author
|
ah, no te habia visto. Merge porque estas cerca, ahora a revisar el sitio online--- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Super Sync septiembre octubre
primavera por acá, lo lamento por todos uds los que viven cabeza abajo.
El próximo sync será mucho más liviano,
en el futuro todas las tareas grandes de revisión de conflictos las derivaré a issues para tomarlas individualmente sin la presion de los conflictos,
como empecé a hacer con algunas aquí y como dejé asentado en el
issue procedimiento #388
@vplentinax
PF revisalo para añadir el sync rápido y evitar tooooodos los conflictos que se vienen encima...