Skip to content

Unicode: flag "u" and class \p{...}#266

Merged
vplentinax merged 8 commits intojavascript-tutorial:masterfrom
cortizg:es.javascript.info.9-03-u
Jul 7, 2020
Merged

Unicode: flag "u" and class \p{...}#266
vplentinax merged 8 commits intojavascript-tutorial:masterfrom
cortizg:es.javascript.info.9-03-u

Conversation

@cortizg
Copy link
Copy Markdown
Contributor

@cortizg cortizg commented Jun 20, 2020

No description provided.

@javascript-translate-bot
Copy link
Copy Markdown

Error: the article already has PR number in the Progress Issue #17, it's 253 ⁉️

Copy link
Copy Markdown
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solo los dos arreglos recientes del repo EN.
No, en esos arreglos no arreglaron los links a unicode.org, tampoco encontré los correctos.

Jeroglíficos: ¿hay algún chino entre nos? Creo que prefieren decirle ideogramas, pictogramas o algo así. Quizás sea lo mismo, una búsqueda rápida no encontré nada raro.

Acabo de poner flag al glosario como indicador si/no, e Ilya lo pone aca como pattern. Pfff. Creo que se equivoca, pero no importa.

Al segundo reviewer, no me esperen, con esos 2 arreglos lo doy por aprobado.

Comment thread 9-regular-expressions/03-regexp-unicode/article.md Outdated
Comment thread 9-regular-expressions/03-regexp-unicode/article.md Outdated
@javascript-translate-bot
Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

cortizg and others added 2 commits July 5, 2020 08:43
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Copy link
Copy Markdown
Contributor Author

@cortizg cortizg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sinogramas

Comment thread 9-regular-expressions/03-regexp-unicode/article.md Outdated
Comment thread 9-regular-expressions/03-regexp-unicode/article.md Outdated
Comment thread 9-regular-expressions/03-regexp-unicode/article.md Outdated
Comment thread 9-regular-expressions/03-regexp-unicode/article.md Outdated
Comment thread 9-regular-expressions/03-regexp-unicode/article.md Outdated
@cortizg
Copy link
Copy Markdown
Contributor Author

cortizg commented Jul 5, 2020

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 5, 2020 14:49
@cortizg cortizg requested review from joaquinelio and removed request for a team July 5, 2020 14:50
joaquinelio and others added 5 commits July 5, 2020 19:42
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
Co-authored-by: Carlos Ortiz Gutiérrez <56600925+cortizg@users.noreply.github.com>
Copy link
Copy Markdown
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Sinogramas", no lo conocía...
Jeroglifo, escritos sagrados, solo lo vi aplicado a los egipcios,
a chinos, más genéricos: ideogramas, pictogramas, crucigramas... ah no, ese no.

Copy link
Copy Markdown
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge!

@vplentinax vplentinax merged commit 61666f6 into javascript-tutorial:master Jul 7, 2020
@javascript-translate-bot
Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants