Skip to content

Suggestion #3278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iliakan merged 2 commits into from
Jan 24, 2023
Merged

Suggestion #3278

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e26c7e
Suggestion
bogdanbacosca Nov 26, 2022
ae7afcb
update
bogdanbacosca Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 1-js/02-first-steps/07-type-conversions/article.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ String conversion is mostly obvious. A `false` becomes `"false"`, `null` becomes

## Numeric Conversion

Numeric conversion happens in mathematical functions and expressions automatically.
Numeric conversion in mathematical functions and expressions happen automatically.
Copy link
Copy Markdown
Member

@joaquinelio joaquinelio Nov 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Numeric conversion in mathematical functions and expressions happen automatically.
Numeric conversion happens automatically in mathematical functions and expressions.

warning I am not a native eng speaker

Copy link
Copy Markdown
Contributor Author

@bogdanbacosca bogdanbacosca Nov 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaquinelio your version looks good too

Copy link
Copy Markdown
Member

@joaquinelio joaquinelio Nov 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or, (I like it more but I'm not sure if I can start a sentence this way)

Suggested change
Numeric conversion in mathematical functions and expressions happen automatically.
In mathematical functions and expressions, the numeric conversion happens automatically.


For example, when division `/` is applied to non-numbers:

Expand Down