Conversation
When building on GitHub Actions for a pull request, add a "GitHub pull request" link to the Build Scan by extracting the PR number from the GITHUB_REF_NAME environment variable. See gradle/common-custom-user-data-gradle-plugin#472
dotta
reviewed
Apr 7, 2026
| val pullRequestUrl = for { | ||
| url <- serverUrl | ||
| repository <- gitRepository | ||
| _ <- headRef |
Member
There was a problem hiding this comment.
Why is it required for headRef to be Some? If it's indeed required, I'd lift this out and make it a conditional for the whole expression, i.e.,
if (headRef.nonEmpty) {
val pullRequestUrl = for { ...
}
This because I believe it makes the intended logic a lot more apparent and easier to reason about.
Duhemm
approved these changes
Apr 27, 2026
Member
Duhemm
left a comment
There was a problem hiding this comment.
I think it might make sense to move the PR number extraction logic to a dedicated method so that it's obvious that it'll return something only when we're running in a PR. That'll also address Mirco's concern about the guard being a bit obscure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GITHUB_REF_NAMEenvironment variable (format<number>/merge)Test plan