Skip to content

Docs#405

Closed
paulsmithkc wants to merge 2 commits intogoogle:masterfrom
paulsmithkc:docs
Closed

Docs#405
paulsmithkc wants to merge 2 commits intogoogle:masterfrom
paulsmithkc:docs

Conversation

@paulsmithkc
Copy link
Copy Markdown
Contributor

Initial draft of converting the training pages to markdown and revising the "Send a simple request" lesson.

Feedback more than welcome. Willing to convert the other two pages, just wanted to get some feedback first.

@jpd236
Copy link
Copy Markdown
Collaborator

jpd236 commented Mar 30, 2021

Sorry if I didn't make this clear enough in the bug - I don't think we want to migrate the docs to GitHub at this time; we'd like to keep developer.android.com (DAC) docs as the source of truth for the primary developer-facing documentation given that this has long been the home of these docs, and I don't think it's wise for us to have two differing copies of the same info. We can think about whether DAC is the right home for the long-term, but for the immediate term, I don't think we'll be making changes there.

If it would make reviewing proposed changes easier and you'd prefer to do it in this format - one thing you could maybe do would be to separate the conversion into two commits: one which just does a simple conversion to MarkDown for easier editing, and another which contains the actual changes you'd like to propose. I still wouldn't merge the PR directly, but I could review/comment on the differences by viewing the second commit and work on upstreaming these into the DAC docs.

@paulsmithkc
Copy link
Copy Markdown
Contributor Author

paulsmithkc commented Mar 30, 2021

That's fine and completely understandable. Where/How should I submit the initial markdown conversion? Just open a new PR?

@jpd236
Copy link
Copy Markdown
Collaborator

jpd236 commented Mar 30, 2021

You could always submit to your fork, then link to individual commits in an issue request rather than a PR. (Like this: paulsmithkc@bd1dc54 - except this commit combines both the initial conversion and the edits).

You can also send as a PR once you've split the commits in this fashion, since the PR lets us see the individual commits that went into it. But that may be harder to manage incrementally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants