Skip to content

Pass computeDefaultStrings to query server when compiling queries #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aeisenberg merged 3 commits into from
Dec 1, 2020
Merged

Pass computeDefaultStrings to query server when compiling queries #694

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5dae200
Pass computeDefaultStrings to query server when compiling queries
aeisenberg Nov 30, 2020
2f8a1f9
Update changelog
aeisenberg Dec 1, 2020
ed5dc69
Add query running test for computeDefaultStrings flag
aeisenberg Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions extensions/ql-vscode/src/pure/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,11 @@ export interface CompilationOptions {
* Whether to disable toString values in the results.
*/
noComputeToString: boolean;
/**
* Whether to ensure that elements that do not have a displayString
* get reported anyway. Useful for universal compilation options.
*/
computeDefaultStrings: boolean;
Copy link
Copy Markdown
Contributor

@adityasharad adityasharad Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future work: This makes me think we should have an internal integration test, which checks the external and internal copies of this protocol are in sync.

}

/**
Expand Down
1 change: 1 addition & 0 deletions extensions/ql-vscode/src/run-queries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ export class QueryInfo {
localChecking: false,
noComputeGetUrl: false,
noComputeToString: false,
computeDefaultStrings: true
},
extraOptions: {
timeoutSecs: qs.config.timeoutSecs
Expand Down
1 change: 1 addition & 0 deletions extensions/ql-vscode/src/vscode-tests/no-workspace/query-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ describe('using the query server', function() {
localChecking: false,
noComputeGetUrl: false,
noComputeToString: false,
computeDefaultStrings: true
Comment thread
adityasharad marked this conversation as resolved.
},
queryToCheck: qlProgram,
resultPath: COMPILED_QUERY_PATH,
Expand Down
1 change: 1 addition & 0 deletions extensions/ql-vscode/src/vscode-tests/no-workspace/run-queries.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ describe('run-queries', () => {
localChecking: false,
noComputeGetUrl: false,
noComputeToString: false,
computeDefaultStrings: true
},
extraOptions: {
timeoutSecs: 5
Expand Down