Merged
Conversation
This adds the `codeQL.model.packLocation` setting, which allows users to
specify the location of the CodeQL extension pack. This setting replaces
the `codeQL.model.extensionsDirectory` setting, which has been removed.
The pack location supports variable substitutions and supports both
absolute and relative paths. The default value is
`.github/codeql/extensions/${name}-${language}` which matches the
previous defaults.
6d6e760 to
5fbd912
Compare
shati-patel
approved these changes
Apr 8, 2024
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
Nice! I haven't tested this locally, but the code + tests look sensible ✨
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
codeQL.model.packLocationsetting, which allows users to specify the location of the CodeQL extension pack. This setting replaces thecodeQL.model.extensionsDirectorysetting, which has been removed.The pack location supports variable substitutions and supports both absolute and relative paths. The default value is
.github/codeql/extensions/${name}-${language}which matches the previous defaults.My plan is to add the CHANGELOG entry when all three settings have been added, rather than for each one individually.
Checklist
ready-for-doc-reviewlabel there.