Added filtering and sorting in the model alerts view#3509
Merged
Conversation
shati-patel
approved these changes
Mar 25, 2024
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
A couple of minor comments, but LGTM overall! ✨
…er-sort.ts Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add filtering on model signature or repository, and sorting based on number of results and alphabetically.
The implementation generally follows similar patterns to what we have in the variant analysis results view.
Apologies for the churn in the
alert-processor.tsandModelAlerts.stories.tsx- this is mainly so we can have enough test data to try things out in Storybook since we don't have proper alert provenance information yet.Checklist
N/A:
ready-for-doc-reviewlabel there.