Skip to content

Re-use setRepoResults instead of having a setReposResult message#3506

Merged
charisk merged 1 commit intomainfrom
charisk/remove-unnecessary-msg
Mar 22, 2024
Merged

Re-use setRepoResults instead of having a setReposResult message#3506
charisk merged 1 commit intomainfrom
charisk/remove-unnecessary-msg

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Mar 22, 2024

In #3503 I introduced a new message when I could have just re-used the existing message 🤦 this fixes that.

The setRepoResults message can be re-used because its handling replaces any existing repo results.

I still find the names of messages a bit confusing so that can be tidied up in a separate PR.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested review from a team as code owners March 22, 2024 15:22
@charisk charisk merged commit a6b3d38 into main Mar 22, 2024
@charisk charisk deleted the charisk/remove-unnecessary-msg branch March 22, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants