Generate separate file for generated type models in Ruby by default

[koesie10]

This will generate a separate file models/ruby.model.generated.yml when running the model editor for Ruby and type models are hidden (the default). This file is ignored by the model editor, but stores all type models generated by the query. This is part of hiding type models by default.

Checklist

• CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
• Issues have been created for any UI or other user-facing changes made by this pull request.
• [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

[koesie10]

I'll change this to use the codeQL.model.showTypeModels setting instead of canary mode once #3399 is merged.

[shati-patel]

Looks mostly good, just a few questions! 📝

---

I also had a general comment from testing: When I run Generate from the model editor, there's a log entry saying

CLI command succeeded.
No predicate found for typeVariableModel

I don't think this "typeVariableModel" is necessarily related to your changes, but I also couldn't see exactly where it's coming from 😅 (This is on the nightly CLI version, and a recent main codeql submodule checkout—but I tried a few different versions too 🤔)

[shati-patel]

Why are we getting rid of the parseResults option? 🤔

[koesie10]

parseResults was very specific to producing ModeledMethod[], while that's not something we want to do for this type model generation (we can just put the rows as-is into a YAML file). The only thing that parseResults was used for was await onResults(await parseResults(queryPath, bqrs)), which can very easily be replaced by await onResults(queryPath, bqrs) with very minor changes on the consumer side.

[koesie10]

I don't think this "typeVariableModel" is necessarily related to your changes, but I also couldn't see exactly where it's coming from 😅 (This is on the nightly CLI version, and a recent main codeql submodule checkout—but I tried a few different versions too 🤔)

I believe this has been there since the beginning. The model editor doesn't support typeVariableModel, but it's a predicate that's produced from the generation query. We can ignore this log message.

[shati-patel]

Thanks for the explanations ✨ Looks good!