-
Notifications
You must be signed in to change notification settings - Fork 226
Add model evaluation run to store and view #3385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
extensions/ql-vscode/src/model-editor/model-evaluation-run.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| export interface ModelEvaluationRun { | ||
| isPreparing: boolean; | ||
| variantAnalysisId: number | undefined; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| import type { ModelingStore } from "./modeling-store"; | ||
| import type { ModelingEvents } from "./modeling-events"; | ||
| import type { DatabaseItem } from "../databases/local-databases"; | ||
| import type { ModelEvaluationRun } from "./model-evaluation-run"; | ||
| import { DisposableObject } from "../common/disposable-object"; | ||
| import { sleep } from "../common/time"; | ||
| import type { ModelEvaluationRunState } from "./shared/model-evaluation-run-state"; | ||
|
|
||
| export class ModelEvaluator extends DisposableObject { | ||
| public constructor( | ||
| private readonly modelingStore: ModelingStore, | ||
| private readonly modelingEvents: ModelingEvents, | ||
| private readonly dbItem: DatabaseItem, | ||
| private readonly updateView: ( | ||
| run: ModelEvaluationRunState, | ||
| ) => Promise<void>, | ||
| ) { | ||
| super(); | ||
|
|
||
| this.registerToModelingEvents(); | ||
| } | ||
|
|
||
| public async startEvaluation() { | ||
| // Update store with evaluation run status | ||
| const evaluationRun: ModelEvaluationRun = { | ||
| isPreparing: true, | ||
| variantAnalysisId: undefined, | ||
| }; | ||
| this.modelingStore.updateModelEvaluationRun(this.dbItem, evaluationRun); | ||
|
|
||
| // For now, just wait 5 seconds and then update the store. | ||
| // In the future, this will be replaced with the actual evaluation process. | ||
| void sleep(5000).then(() => { | ||
| const completedEvaluationRun: ModelEvaluationRun = { | ||
| isPreparing: false, | ||
| variantAnalysisId: undefined, | ||
| }; | ||
| this.modelingStore.updateModelEvaluationRun( | ||
| this.dbItem, | ||
| completedEvaluationRun, | ||
| ); | ||
| }); | ||
| } | ||
|
|
||
| public async stopEvaluation() { | ||
| // For now just update the store. | ||
| // This will be fleshed out in the near future. | ||
| const evaluationRun: ModelEvaluationRun = { | ||
| isPreparing: false, | ||
| variantAnalysisId: undefined, | ||
| }; | ||
| this.modelingStore.updateModelEvaluationRun(this.dbItem, evaluationRun); | ||
| } | ||
|
|
||
| private registerToModelingEvents() { | ||
| this.push( | ||
| this.modelingEvents.onModelEvaluationRunChanged(async (event) => { | ||
| if ( | ||
| event.evaluationRun && | ||
| event.dbUri === this.dbItem.databaseUri.toString() | ||
| ) { | ||
| const run: ModelEvaluationRunState = { | ||
| isPreparing: event.evaluationRun.isPreparing, | ||
|
|
||
| // TODO: Get variant analysis from id. | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will do this in the next PR. It needs the |
||
| variantAnalysis: undefined, | ||
| }; | ||
| await this.updateView(run); | ||
| } | ||
| }), | ||
| ); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
extensions/ql-vscode/src/model-editor/shared/model-evaluation-run-state.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import { VariantAnalysisStatus } from "../../variant-analysis/shared/variant-analysis"; | ||
| import type { VariantAnalysis } from "../../variant-analysis/shared/variant-analysis"; | ||
|
|
||
| export interface ModelEvaluationRunState { | ||
| isPreparing: boolean; | ||
| variantAnalysis: VariantAnalysis | undefined; | ||
| } | ||
|
|
||
| export function modelEvaluationRunIsRunning( | ||
| run: ModelEvaluationRunState, | ||
| ): boolean { | ||
| return ( | ||
| run.isPreparing || | ||
| !!( | ||
| run.variantAnalysis && | ||
| run.variantAnalysis.status === VariantAnalysisStatus.InProgress | ||
| ) | ||
| ); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.