Add test for model packs in MRVA to test plan#3370
Merged
Conversation
Contributor
robertbrignull
left a comment
There was a problem hiding this comment.
LGTM once the released CLI supports this
Member
Author
|
v2.16.3 of the CLI now supports this, so this is ready to be merged (once it's been approved). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a test for a model pack in MRVA that should always work and is independent of changes in the CodeQL libraries (unless the actual
sinkModelis changed). Unfortunately, that does involve creating a few files manually.Checklist
ready-for-doc-reviewlabel there.