Add functions for parsing and validating access paths#3218
Merged
Conversation
This adds functions for parsing and validating access paths to prepare for future functionality where we're going to be parsing and validating access paths.
shati-patel
approved these changes
Jan 11, 2024
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
Thanks for adding the tests and the clear descriptions! 👍🏽
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds functions for parsing and validating access paths (such as
Argument[foo].Element.Field[foo.Bar.x]) to prepare for future functionality where we're going to be parsing and validating access paths. These functions are not yet used in this PR.See the description of the
access-paths.tsfor the reasons for manually parsing the access path rather than simply splitting by.or using a regex.Example result of
parseAccessPathTokens(from the test):Input:
Argument[foo].Element.Field[foo.Bar.x]Output:
[ { "range": { "start": 0, "end": 13 }, "text": "Argument[foo]" }, { "range": { "start": 14, "end": 21 }, "text": "Element" }, { "range": { "start": 22, "end": 38 }, "text": "Field[foo.Bar.x]" } ]Checklist
ready-for-doc-reviewlabel there.