Remove legacy messages

[koesie10]

This removes all remaining usages of legacy messages. The first commit changes the most: It removes the result on a QueryHistoryItem, which was populated based on information that is already present in CompletedQueryInfo anyway. Old history items which only have the legacy result populated have not been created for at least 30 days now since the legacy query runner hasn't been used for quite a while now. Therefore, we can safely remove it.

Checklist

• CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
• Issues have been created for any UI or other user-facing changes made by this pull request.
• [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

[charisk]

What is the significance of the 30 days? Is that the default query history item expiry time? I believe that's configurable so someone may have changed it. What would happen in that case (I've not looked at the code changes yet)?

[koesie10]

What is the significance of the 30 days? Is that the default query history item expiry time? I believe that's configurable so someone may have changed it. What would happen in that case (I've not looked at the code changes yet)?

Yes, exactly. However, I think this should actually be fine for all query history items created in the extension in at least the last year. When we enabled the new query server by default, we were already setting successful and message. So, even for those items it should work correctly. Only for items which are even older (created in extension versions before v1.7.1, #1498), would users now not be able to see the status or view results. However, the extension doesn't crash since there's a default for these. They would also still be able to retrieve the BQRS and SARIF files.

[charisk]

Thanks! It's great to see this cleaned up. I can't think of anything wrong with these changes.

[charisk]

Should this go in new-messages.ts?

Also should we rename new-messages.ts (and I guess new-query-runner.ts)? Happy for that to be a follow up.

[koesie10]

Not really, since this is not a message that is produced by the query server. This message is only produced for tests, and never as part of a query run. Therefore, I don't think it makes sense to move it to new-messages.ts.

I can rename new-messages.ts in a follow-up PR. new-query-runner.ts has already been renamed as part of #3171