Skip to content

Fix loading message for compare view #3107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koesie10 merged 2 commits into from
Dec 6, 2023
Merged

Fix loading message for compare view #3107

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddf4407
Fix loading message for compare view
koesie10 Dec 6, 2023
a42e9eb
Update CHANGELOG
koesie10 Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions extensions/ql-vscode/src/view/compare/Compare.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,23 +11,14 @@ import CompareTable from "./CompareTable";

import "../results/resultsView.css";

const emptyComparison: SetComparisonsMessage = {
t: "setComparisons",
stats: {},
result: undefined,
commonResultSetNames: [],
currentResultSetName: "",
databaseUri: "",
message: "Empty comparison",
};

export function Compare(_: Record<string, never>): JSX.Element {
const [comparison, setComparison] =
useState<SetComparisonsMessage>(emptyComparison);
const [comparison, setComparison] = useState<SetComparisonsMessage | null>(
null,
);

const message = comparison.message || "Empty comparison";
const message = comparison?.message || "Empty comparison";
const hasRows =
comparison.result &&
comparison?.result &&
(comparison.result.to.length || comparison.result.from.length);

useEffect(() => {
Expand All @@ -50,6 +41,7 @@ export function Compare(_: Record<string, never>): JSX.Element {
window.removeEventListener("message", listener);
};
}, []);

if (!comparison) {
return <div>Waiting for results to load.</div>;
}
Expand Down