Skip to content

Remove unnecessary ModelKindDropdown input#3046

Merged
charisk merged 1 commit intomainfrom
charisk/remove-unnecessary-input
Nov 1, 2023
Merged

Remove unnecessary ModelKindDropdown input#3046
charisk merged 1 commit intomainfrom
charisk/remove-unnecessary-input

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Nov 1, 2023

I noticed that the method input was not used in the ModelKindDropdown so I got rid of it.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner November 1, 2023 14:52
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it compiles still.

I think I noticed this too, or maybe another similar unused prop. Are our linting rules not catching unused React component props?

@charisk
Copy link
Copy Markdown
Contributor Author

charisk commented Nov 1, 2023

I think I noticed this too, or maybe another similar unused prop. Are our linting rules not catching unused React component props?

Yep. I've raised an internal issue to tidy that up (linked to the PR).

@charisk charisk merged commit 7adc114 into main Nov 1, 2023
@charisk charisk deleted the charisk/remove-unnecessary-input branch November 1, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants