Merged
Conversation
e2729f3 to
693adb5
Compare
starcke
approved these changes
Nov 3, 2023
Contributor
starcke
left a comment
There was a problem hiding this comment.
Looks good to me. Just a question.
| const maxStep = filteredQueryPaths.length * 1000; | ||
|
|
||
| for (let i = 0; i < filteredQueryPaths.length; i++) { | ||
| const queryPath = filteredQueryPaths[i]; |
Contributor
There was a problem hiding this comment.
I dont think this is a problem, but would this just ignore it if one of the queries wasnt found whereas before it would error?
Member
Author
There was a problem hiding this comment.
Yes, that's another difference that I forgot to mention. It should still error if it doesn't find any queries, so I think this is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unifies the two code paths for model generation (flow model generation/generate model) by moving it to the language definition. There are some user-visible changes:
CaptureSinkModels.qlinstead ofsink. Same for the other queries.Checklist
ready-for-doc-reviewlabel there.