Merged
Conversation
This allows more disjointed models to be represented more accurately, such as type models.
Contributor
robertbrignull
left a comment
There was a problem hiding this comment.
I think this looks really good! I like splitting the ModeledMethod type up so that each sub-type only contains the fields it needs.
I have a few small comments asking for clarification or small improvements, but the overall idea and changes look great.
robertbrignull
approved these changes
Nov 1, 2023
Contributor
robertbrignull
left a comment
There was a problem hiding this comment.
LGTM
(Has some conflicts in imports, but they didn't seem hard to fix)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches the
ModeledMethodtype from 1 type containing all fields to a union of multiple types where each type accurately represents which fields are present for a specific model. This allows more disjointed models to be represented more accurately, such as type models. For type models, havinginput,output, etc. doesn't make sense. It instead has fields liketype1,type2andpath. I don't think adding these properties to every modeled method makes sense, so this is a solution which allows us to represent both models.This is a very large changeset, but I don't think splitting it up would be helpful (I don't really see how). A lot of the changes are changes to method names or removing unnecessary properties.
Checklist
ready-for-doc-reviewlabel there.