Skip to content

Remove resolveCanonicalUsage method#2978

Closed
robertbrignull wants to merge 1 commit intomainfrom
robertbrignull/remove_canonical_usage
Closed

Remove resolveCanonicalUsage method#2978
robertbrignull wants to merge 1 commit intomainfrom
robertbrignull/remove_canonical_usage

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

Another benefit of the modeleing store is that we no longer need the resolveCanonicalUsage method.

This was needed because we were passing Method objects to and from the webview and this caused them to become new javascript objects. We now keep the canonical objects purely on the extension host side, so when jumping to a usage we already have the canonical objects available.

When testing this, remember to merge in #2977. These do not conflict, but jumping to usages does not work without that PR.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team as a code owner October 16, 2023 09:46
@koesie10
Copy link
Copy Markdown
Member

In #2976 I do need this method (although I've renamed it as resolveUsageTreeViewItem) since I'm creating separate tree view items here. Would it make sense to first review #2976 and close this PR if that PR gets merged?

@robertbrignull
Copy link
Copy Markdown
Contributor Author

Sounds good. I'll take a look at that other PR.

@robertbrignull
Copy link
Copy Markdown
Contributor Author

Closing as the method is now used by #2976

@robertbrignull robertbrignull deleted the robertbrignull/remove_canonical_usage branch October 16, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants