Skip to content

Only include method signatures in generateMethodsFromLlm message#2927

Merged
robertbrignull merged 1 commit intomainfrom
robertbrignull/generateMethodsFromLlm
Oct 10, 2023
Merged

Only include method signatures in generateMethodsFromLlm message#2927
robertbrignull merged 1 commit intomainfrom
robertbrignull/generateMethodsFromLlm

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

Updates the generateMethodsFromLlm message to not include the full Method and ModeledMethod objects, but instead to only include the method signatures and let the modeling store provide the full canonical data.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested review from a team as code owners October 9, 2023 15:19
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread extensions/ql-vscode/src/model-editor/model-editor-view.ts
@robertbrignull robertbrignull merged commit 4dcfa8b into main Oct 10, 2023
@robertbrignull robertbrignull deleted the robertbrignull/generateMethodsFromLlm branch October 10, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants