Skip to content

Convert remaining extension host code to handle multiple models#2906

Merged
koesie10 merged 4 commits intomainfrom
koesie10/convert-remaining-multiple-models
Oct 10, 2023
Merged

Convert remaining extension host code to handle multiple models#2906
koesie10 merged 4 commits intomainfrom
koesie10/convert-remaining-multiple-models

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Oct 4, 2023

This converts all remaining extension host code to handle multiple models per method. The only place where we're using the legacy format is in the webview and in the boundary between the webview and the extension host.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review October 4, 2023 12:44
@koesie10 koesie10 requested a review from a team as a code owner October 4, 2023 12:44
Base automatically changed from koesie10/convert-modeled-method-fs to main October 9, 2023 09:54
This converts all remaining extension host code to handle multiple
models per method. The only place where we're using the legacy format
is in the webview and in the boundary between the webview and the
extension host.
@koesie10 koesie10 force-pushed the koesie10/convert-remaining-multiple-models branch from 3afed56 to b763693 Compare October 9, 2023 11:56
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has some conflicts too that'll need fixing. I can do another review once the PR is updated.

Comment thread extensions/ql-vscode/src/model-editor/modeled-methods-legacy.ts Outdated
@koesie10 koesie10 enabled auto-merge October 10, 2023 09:35
@koesie10 koesie10 merged commit 319a54c into main Oct 10, 2023
@koesie10 koesie10 deleted the koesie10/convert-remaining-multiple-models branch October 10, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants