Relax 'resolve ram' test#2805
Merged
shati-patel merged 1 commit intomainfrom Sep 12, 2023
Merged
Conversation
The test currently assumes that the CLI will use an exact 50/50 split between heap and off-heap RAM, but this is not guaranteed. Relax the test so that it doesn't care about the specific numbers.
shati-patel
approved these changes
Sep 12, 2023
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
Looks good, thanks! 🌷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test currently assumes that the CLI will use an exact 50/50 split between heap and off-heap RAM, but this is not guaranteed. Relax the test so that it doesn't care about the specific numbers.