Make methodModelingView match the naming of other flags#2771
Merged
robertbrignull merged 1 commit intomainfrom Sep 1, 2023
Merged
Make methodModelingView match the naming of other flags#2771robertbrignull merged 1 commit intomainfrom
robertbrignull merged 1 commit intomainfrom
Conversation
charisk
approved these changes
Sep 1, 2023
Contributor
charisk
left a comment
There was a problem hiding this comment.
I'm happy either way but if we're going ahead with this we'll want to update the internal docs too.
Contributor
Author
|
I think go for it because it's a bit incongruous having one with a different prefix @norascheuch, you'll have to update your local feature flags. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the
codeQL.modelEditor.methodModelingViewfeature flag tocodeQL.model.methodModelingViewso that it matches the prefix of the other modeling feature flags.I'm guessing what happened is we were trying to preempt the change in #2766, but then we changed our mind to use
codeQL.modelinstead ofcodeQL.modelEditor, so thecodeQL.modelEditor.methodModelingViewdoesn't match the other flags now.Checklist
ready-for-doc-reviewlabel there.