Skip to content

Make methodModelingView match the naming of other flags#2771

Merged
robertbrignull merged 1 commit intomainfrom
robertbrignull/normalize-feature-flag
Sep 1, 2023
Merged

Make methodModelingView match the naming of other flags#2771
robertbrignull merged 1 commit intomainfrom
robertbrignull/normalize-feature-flag

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

Renames the codeQL.modelEditor.methodModelingView feature flag to codeQL.model.methodModelingView so that it matches the prefix of the other modeling feature flags.

I'm guessing what happened is we were trying to preempt the change in #2766, but then we changed our mind to use codeQL.model instead of codeQL.modelEditor, so the codeQL.modelEditor.methodModelingView doesn't match the other flags now.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team September 1, 2023 09:22
@robertbrignull robertbrignull requested a review from a team as a code owner September 1, 2023 09:22
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy either way but if we're going ahead with this we'll want to update the internal docs too.

@robertbrignull
Copy link
Copy Markdown
Contributor Author

I think go for it because it's a bit incongruous having one with a different prefix

@norascheuch, you'll have to update your local feature flags.

@robertbrignull robertbrignull merged commit b5d6c4d into main Sep 1, 2023
@robertbrignull robertbrignull deleted the robertbrignull/normalize-feature-flag branch September 1, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants