Add ability to set method for modeling in the modeling panel#2767
Add ability to set method for modeling in the modeling panel#2767
Conversation
f82613e to
e9bb357
Compare
robertbrignull
left a comment
There was a problem hiding this comment.
Code all looks ok to me, but sadly it didn't work when I tested it. I didn't see any error messages though. It just didn't show the usages panel or the new modeling panel.
| } | ||
|
|
||
| public async setMethod(method: ExternalApiUsage): Promise<void> { | ||
| if (this.webviewView) { |
There was a problem hiding this comment.
This doesn't seem to be working for me. At the point it reaches this point this.webviewView is undefined. Does it work for you? 🤔
There was a problem hiding this comment.
This seems to be because resolveWebviewView isn't called until the user manually expands the tab. The tab was there, but it wasn't responding when I selected a method until I had manually expanded it.
Perhaps we could automatically initialise the view and not rely on the user. But that could be a separate PR from this one. Once I expanded the view it was behaving as expected 🎉
e9bb357 to
56c8eb2
Compare
…ew.tsx Co-authored-by: Robert <robertbrignull@github.com>
This PR adds some initial wire-up for the method modeling panel. It first adds the ability to set the method that is being modeled, and then adds some basic wire up so that a dummy method is shown when the user clicks the "View" button in the editor. I've not wired up the actual method information yet because it requires some refactoring to make that available (we only have the
Usageat the minute). This will be done in a following PR.Note that I've broken this into 3 commits for ease of review.
Checklist
N/A:
ready-for-doc-reviewlabel there.