-
Notifications
You must be signed in to change notification settings - Fork 226
Add a dropdown for choosing MRVA result format #2743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
27 changes: 27 additions & 0 deletions
27
extensions/ql-vscode/src/stories/variant-analysis/RepositoriesResultFormat.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import * as React from "react"; | ||
| import { useState } from "react"; | ||
|
|
||
| import { Meta } from "@storybook/react"; | ||
|
|
||
| import { RepositoriesResultFormat as RepositoriesResultFormatComponent } from "../../view/variant-analysis/RepositoriesResultFormat"; | ||
| import { ResultFormat } from "../../variant-analysis/shared/variant-analysis-result-format"; | ||
|
|
||
| export default { | ||
| title: "Variant Analysis/Repositories Result Format", | ||
| component: RepositoriesResultFormatComponent, | ||
| argTypes: { | ||
| value: { | ||
| control: { | ||
| disable: true, | ||
| }, | ||
| }, | ||
| }, | ||
| } as Meta<typeof RepositoriesResultFormatComponent>; | ||
|
|
||
| export const RepositoriesResultFormat = () => { | ||
| const [value, setValue] = useState(ResultFormat.Alerts); | ||
|
|
||
| return ( | ||
| <RepositoriesResultFormatComponent value={value} onChange={setValue} /> | ||
| ); | ||
| }; |
4 changes: 4 additions & 0 deletions
4
extensions/ql-vscode/src/variant-analysis/shared/variant-analysis-result-format.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| export enum ResultFormat { | ||
| Alerts = "Alerts", | ||
| RawResults = "Raw results", | ||
| } |
40 changes: 40 additions & 0 deletions
40
extensions/ql-vscode/src/view/variant-analysis/RepositoriesResultFormat.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import * as React from "react"; | ||
| import { useCallback } from "react"; | ||
| import { styled } from "styled-components"; | ||
| import { VSCodeDropdown, VSCodeOption } from "@vscode/webview-ui-toolkit/react"; | ||
| import { Codicon } from "../common"; | ||
| import { ResultFormat } from "../../variant-analysis/shared/variant-analysis-result-format"; | ||
|
|
||
| const Dropdown = styled(VSCodeDropdown)` | ||
| width: 100%; | ||
| `; | ||
|
|
||
| type Props = { | ||
| value: ResultFormat; | ||
| onChange: (value: ResultFormat) => void; | ||
|
|
||
| className?: string; | ||
| }; | ||
|
|
||
| export const RepositoriesResultFormat = ({ | ||
| value, | ||
| onChange, | ||
| className, | ||
| }: Props) => { | ||
| const handleInput = useCallback( | ||
| (e: InputEvent) => { | ||
| const target = e.target as HTMLSelectElement; | ||
|
|
||
| onChange(target.value as ResultFormat); | ||
| }, | ||
| [onChange], | ||
| ); | ||
|
|
||
| return ( | ||
| <Dropdown value={value} onInput={handleInput} className={className}> | ||
| <Codicon name="table" label="Result format..." slot="indicator" /> | ||
| <VSCodeOption value={ResultFormat.Alerts}>Alerts</VSCodeOption> | ||
| <VSCodeOption value={ResultFormat.RawResults}>Raw results</VSCodeOption> | ||
| </Dropdown> | ||
| ); | ||
| }; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use the enum values here too since they have the same text as we want.
BTW, I don't remember using string enum values with spaces in them 🤔 I've looked in our repo and it doesn't look like we're following any kind of convention though (some are capital case, some lower case, some camel case, some pascal case, and in some rare occasions we have spaces 😓 ).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! And yeah, it looks like we're pretty inconsistent with enums 🙈