Skip to content

Move sarif-parser.test.ts from no-workspace to unit-tests#2671

Merged
robertbrignull merged 2 commits intomainfrom
robertbrignull/sarif-parser-unit-test
Aug 4, 2023
Merged

Move sarif-parser.test.ts from no-workspace to unit-tests#2671
robertbrignull merged 2 commits intomainfrom
robertbrignull/sarif-parser-unit-test

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

I'm not sure why these tests were in the no-workspace suite. The code they test is in extensions/ql-vscode/src/common/ and has no vscode dependencies.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team August 3, 2023 16:32
@robertbrignull robertbrignull requested a review from a team as a code owner August 3, 2023 16:32
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@robertbrignull
Copy link
Copy Markdown
Contributor Author

I've moved the test sarif data files from test/vscode-tests/no-workspace/data/sarif to test/data/sarif. I think this is a more suitable shared location for the test data.
We had tests in no-workspace (moved to unit-tests in this PR), activated-workspace, and react view tests. Since there's no one suitable suite to put the data, I think at the top level of the test directory makes most sense.

@robertbrignull robertbrignull disabled auto-merge August 4, 2023 09:00
@robertbrignull robertbrignull merged commit de8d0df into main Aug 4, 2023
@robertbrignull robertbrignull deleted the robertbrignull/sarif-parser-unit-test branch August 4, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants